On Sun, 22 Sep 2024 02:01:36 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Shaojin Wen has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 23 additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'upstream/master' into >> optim_str_builder_append_202406 >> - Merge remote-tracking branch 'origin/optim_str_builder_append_202406' >> into optim_str_builder_append_202406 >> - Merge remote-tracking branch 'upstream/master' into >> optim_str_builder_append_202406 >> - Merge remote-tracking branch 'upstream/master' into >> optim_str_builder_append_202406 >> - revert test >> - Merge remote-tracking branch 'upstream/master' into >> optim_str_builder_append_202406 >> - Merge remote-tracking branch 'upstream/master' into >> optim_str_builder_append_202406 >> - replace unsafe with putChar >> - Merge remote-tracking branch 'upstream/master' into >> optim_str_builder_append_202406 >> - private static final field `UNSAFE` >> - ... and 13 more: https://git.openjdk.org/jdk/compare/7ba4356c...399c8ef5 > > test/hotspot/jtreg/compiler/patches/java.base/java/lang/Helper.java line 136: > >> 134: >> 135: public static int putCharsAt(byte[] value, int i, char c1, char c2, >> char c3, char c4) { >> 136: return StringUTF16.putCharsAt(value, i, c1, c2, c3, c4); > > Why do we remove the tests for UTF16? And should we add another set of test > for LATIN1 too? An early version removed putCharsAt, so it was also removed from Helpers. I have added it back. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19626#discussion_r1770586891
