On Fri, 6 Sep 2024 13:16:34 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Looks good. I'll review the CSR when its ready. > >> Looks good. I'll review the CSR when its ready. > > Thanks. > >> The changes to make jdk.jsobject an upgradeable module looks right. > > Thanks for checking. My testing primarily focused on this aspect of the > change, so it's pretty well tested. > >> I was initially surprised by the wording "will be delivered with JavaFX" but >> after playing with a few alternatives I concluded that what we have is okay. > > Yeah, I tried a few variants and couldn't come up with anything better. @kevinrushforth Is the CSR on your list to write? ------------- PR Comment: https://git.openjdk.org/jdk/pull/20555#issuecomment-2366841622
