On Mon, 12 Aug 2024 17:22:47 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> Deprecate the `jdk.jsobject` module for removal from the JDK, and ship it > with JavaFX instead. > > See [JDK-8337280](https://bugs.openjdk.org/browse/JDK-8337280) / PR > openjdk/jfx#1529 for the JavaFX PR that will include the module with JavaFX. > That PR describes the needed test scenarios. > > This PR does two things: > > 1. Deprecates the `jdk.jsobject` module for removal; the javadoc indicates > that the module will be delivered with JavaFX > 2. Makes `jdk.jsobject` an upgradeable module, which will facilitate the > transition by allowing the version of the module shipped with JavaFX to be > used in favor of the deprecated module in the JDK itself. The changes to make jdk.jsobject an upgradeable module looks right. I was initially surprised by the wording "will be delivered with JavaFX" but after playing with a few alternatives I concluded that what we have is okay. ------------- Marked as reviewed by alanb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/20555#pullrequestreview-2284861631