On Thu, 29 Aug 2024 22:11:36 GMT, Ioi Lam <ik...@openjdk.org> wrote:
>> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>>
>> Add the following command-line options as specified in JEP 483:
>>
>>
>> - `-XX:AOTMode=off/record/create/auto/on`
>> - `-XX:AOTConfiguration=<file>.aotconfig`
>> - `-XX:AOTCache=<file>.aot`
>>
>> These options are implemented as aliases to existing command-line flags such
>> as `-Xshare:dump`, `-XX:SharedArchiveFile`, `-XX:DumpLoadedClassesList`, etc.
>>
>> Please see the CSR (TODO) for detailed specification.
>>
>> -----
>> See [here](https://bugs.openjdk.org/browse/JDK-8315737) for the sequence of
>> dependent RFEs for implementing JEP 483.
>
> Ioi Lam has updated the pull request incrementally with one additional commit
> since the last revision:
>
> @dholmes-ora comments: do not check for -XX:AOTMode=create in JLI java.c
src/hotspot/share/cds/metaspaceShared.cpp line 673:
> 671: }
> 672:
> 673: if (AOTMode != nullptr && strcmp(AOTMode, "create") == 0) {
Would it be better to wrap this test in a CDSConfig::is_ method; which in turn
can test the AOTMode FLAG directly or test
(CDSConfig::is_dumping_static_archive() &&
!CDSConfig::is_old_cds_flags_used()), the point being that the meaning of the
test is captured in the method name, but the test itself can change over time
as needed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20516#discussion_r1767582528
