On Thu, 29 Aug 2024 04:24:02 GMT, Ioi Lam <ik...@openjdk.org> wrote:
>> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>>
>> Add the following command-line options as specified in JEP 483:
>>
>>
>> - `-XX:AOTMode=off/record/create/auto/on`
>> - `-XX:AOTConfiguration=<file>.aotconfig`
>> - `-XX:AOTCache=<file>.aot`
>>
>> These options are implemented as aliases to existing command-line flags such
>> as `-Xshare:dump`, `-XX:SharedArchiveFile`, `-XX:DumpLoadedClassesList`, etc.
>>
>> Please see the CSR (TODO) for detailed specification.
>>
>> -----
>> See [here](https://bugs.openjdk.org/browse/JDK-8315737) for the sequence of
>> dependent RFEs for implementing JEP 483.
>
> Ioi Lam has updated the pull request with a new target base due to a merge or
> a rebase. The incremental webrev excludes the unrelated changes brought in by
> the merge/rebase. The pull request contains five additional commits since the
> last revision:
>
> - Fixed copyright dates
> - Merge branch 'master' of https://github.com/openjdk/jdk into
> jep-483-step-01-8338017-add-aot-command-line-aliases
> - Merge branch 'master' into
> jep-483-step-01-8338017-add-aot-command-line-aliases
> - Fixed whitespaces
> - 8338017: Add AOT command-line flag aliases
Seems reasonable but one issue flagged below.
Thanks.
src/java.base/share/native/libjli/java.c line 1521:
> 1519: dumpSharedSpaces = JNI_TRUE;
> 1520: }
> 1521: if (JLI_StrCmp(arg, "-XX:AOTMode=create") == 0) {
This is inappropriate - the launcher does not, and should not, process hotspot
-XX options. Any aliasing should happen in the hotspot argument processing
logic.
-------------
Changes requested by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20516#pullrequestreview-2267689489
PR Review Comment: https://git.openjdk.org/jdk/pull/20516#discussion_r1735573603
