On Wed, 18 Sep 2024 12:35:28 GMT, Emanuel Peter <epe...@openjdk.org> wrote:
>> src/hotspot/cpu/x86/x86.ad line 6578: >> >>> 6576: %} >>> 6577: ins_pipe( pipe_slow ); >>> 6578: %} >> >> Above, you name both the `format` and method name with `_reg` and `_mem`, >> but here you do not do it for the method name. Would be nice to keep it >> consistent. > > Below you also do it inconsistently. > Above, you name both the `format` and method name with `_reg` and `_mem`, but > here you do not do it for the method name. Would be nice to keep it > consistent. Memory operands are sufficient to implicitly infer memory flavor of opto assembly instruction. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20507#discussion_r1765088839
