On Wed, 18 Sep 2024 12:34:58 GMT, Emanuel Peter <epe...@openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Missed code fragment from last review comment resolution. > > src/hotspot/cpu/x86/x86.ad line 6578: > >> 6576: %} >> 6577: ins_pipe( pipe_slow ); >> 6578: %} > > Above, you name both the `format` and method name with `_reg` and `_mem`, but > here you do not do it for the method name. Would be nice to keep it > consistent. Below you also do it inconsistently. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20507#discussion_r1764976079
