On Mon, 16 Sep 2024 10:11:58 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - merge latest from master branch >> - fix code comment style where appropriate >> - typos >> - 8340114: Remove outdated SelectVersion() function from the launcher and >> update the code comments explaining the code flow > > src/java.base/macosx/native/libjli/java_md_macosx.m line 108: > >> 106: * >> 107: * - JavaMain then returns back an integer result which then gets >> propagated as a return value all the way out >> 108: * of the JLI_Launch function. > > Are you going to re-flow this comment block o reduce the line lengths, the > really long lines are a bit annoying for side-by-side diffs and also > inconsistent with the rest of the file. Hello Alan, I just pushed a update to the PR to reduce the line length of these comments. I'm hoping this reads better. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20997#discussion_r1760947736