On Thu, 12 Sep 2024 10:29:24 GMT, Raffaello Giulietti <rgiulie...@openjdk.org>
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use supported annotation by jtreg in tests
>
> src/java.base/share/classes/java/math/MutableBigInteger.java line 722:
>
>> 720: * {@code (resPos <= offset || resPos >= offset + intLen)}.
>> 721: */
>> 722: private final void primitiveRightShift(int n, int[] result, int
>> resPos) {
>
> Suggestion:
>
> private final void primitiveRightShift(int n, int[] result, int resOff) {
>
> or something more similar to "offset".
>
> Same for the left shift.
What about `resFrom`, like the old `MBI.copyAndshift()` method?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20008#discussion_r1756665227
