On Wed, 11 Sep 2024 19:15:47 GMT, Ioi Lam <ik...@openjdk.org> wrote: > The logic seems to be correct (or at least err on the side of safety and > recompute hasSplitPackages/hasIncubatorModules when we aren't 100% sure).
Just to say a bit more about this. When you specify an application module path to the java launcher then you don't know in advance which modules on the module path will be resolved and whether an incubator module will be resolved. So if startup generates a new Configuration then it has to be checked for incubator modules so that a warning can be printed. The issue we have isn't really a bug, it's that the prototype CDS changes piggyback on the flag used to say if we need to check for incubator modules. With the changes, the flag is renamed to mayContainIncubatorModules to avoid any confusion. As part of dumping, the generated Configuration is checked for incubating modules so that archiving of the boot layer (or "FMG" as CDS refers to it) can be skipped. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20818#issuecomment-2345503053
