On Wed, 11 Sep 2024 09:19:21 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this trivial change which replaces the usages >> of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment? >> >> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are >> outdated and support for them will soon be deprecated and removed as part of >> https://bugs.openjdk.org/browse/JDK-8286851. >> >> There are some more tests remaining in client-libs area which too require a >> similar change. I'll be creating a separate JBS issue and PR for that. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > Alexey's suggestion - remove @author tags The Cache.java change, and the others, look good to me. ------------- Marked as reviewed by ascarpino (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/20930#pullrequestreview-2297774755
