On Wed, 11 Sep 2024 14:13:50 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:
>> Please review this PR which adds test support for systemd slices so that >> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be >> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on >> cgroups v1 and cgroups v2 (since >> [JDK-8322420](https://bugs.openjdk.org/browse/JDK-8322420) is fixed now). >> >> I'm adding those tests in order to not regress another time. >> >> Testing: >> - [x] Container tests on Linux x86_64 cgroups v2 and Linux x86_64 cgroups v1. >> - [x] New systemd test on cg v1 and cg v2 (passes). >> - [x] GHA > > Severin Gehwolf has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 20 additional > commits since the last revision: > > - Remove test from problem list as the bug is fixed > - Merge branch 'master' into jdk-8333446-systemd-slice-tests > - Improve reliability of cpu quota test > - Adapt JDK-8339148 > - Merge branch 'master' into jdk-8333446-systemd-slice-tests > - Merge branch 'master' into jdk-8333446-systemd-slice-tests > - Fix comment of WB::host_cpus() > - Handle non-root + CGv2 > - Add nested hierarchy to test framework > - Revert "Add root check for SystemdMemoryAwarenessTest.java" > > This reverts commit 7e8d9ed46815096ae8c4502f3320ebf5208438d5. > - ... and 10 more: https://git.openjdk.org/jdk/compare/4356d152...88298b99 I've merged master and removed the test from the problem list since the relevant bug got fixed. @MBaesken Said changes require a re-review before this patch would be ready for integration. Could you please take another look? Thank you! ------------- PR Comment: https://git.openjdk.org/jdk/pull/19530#issuecomment-2343834760
