On Mon, 9 Sep 2024 12:07:54 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> Hi all, >> This PR delete tedious bool type define in >> `src/java.base/unix/native/libjsig/jsig.c` and >> `src/utils/hsdis/binutils/hsdis-binutils.c`. After JEP >> 347([JDK-8246032](https://bugs.openjdk.org/browse/JDK-8246032)), I think we >> can "#include <stdbool.h>" to use bool type directly, like >> [string.h](https://github.com/openjdk/jdk/blob/master/src/java.desktop/unix/native/libpipewire/include/spa/utils/string.h#L13) >> do. >> Make code more concision, the risk is quite low. >> >> Additional testing: >> >> - [x] Local build with --with-hsdis=binutils >> --with-binutils=$HOME/software/binutils >> - [ ] Jtreg tests(include tier1/tier2/tier3 etc.) on linux x64 >> - [ ] Jtreg tests(include tier1/tier2/tier3 etc.) on linux aarch64 > > src/utils/hsdis/binutils/hsdis-binutils.c line 67: > >> 65: #include "hsdis.h" >> 66: >> 67: #ifndef bool > > I'm a little worried about this change. hsdis may really need an int here. If > that turns out to not be the case then I'll retract my concerns I have verified this change locally, include build hsdis.so and check the functional with command java -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -version. The verified show this change for hsdis.so work normally. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20909#discussion_r1750211438
