On Fri, 6 Sep 2024 21:49:30 GMT, Naoto Sato <na...@openjdk.org> wrote:

>> Fixing TZDB build tool to accommodate full month/day names. Recently 
>> released tzdb2024b included (inadvertently) full month name "April", which 
>> is allowed by the spec (zic.8), but never used. This will cause build 
>> failure of the JDK. The proposed fix is manually tested by modifying the 
>> tzdb files to include full month names, and confirmed the successful build 
>> of the JDK.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Strictly conforming to the spec

Marked as reviewed by jlu (Committer).

New fix LGTM.

> Month names may be abbreviated as mentioned previously;
> for example, January can appear as
> .q January ,
> .q JANU
> or
> .q Ja ,
> but not as
> .q j

So I think it's safe to assume unambiguous abbreviations.

-------------

PR Review: https://git.openjdk.org/jdk/pull/20893#pullrequestreview-2287223428
PR Comment: https://git.openjdk.org/jdk/pull/20893#issuecomment-2334879456

Reply via email to