On Fri, 6 Sep 2024 09:16:28 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> This fixes some of the recently discovered [issues] with the block variants >> of the specification tags. While reviewing, please check the proposed >> changes against the actual specifications. Since the specifications for JDK >> 23 are not yet available in the HTML format, you can use the specifications >> for JDK 22, which are reasonably up-to-date: >> >> - [JLS] >> - [JVMS] >> >> Note that this PR does NOT address any issues with the inline variants of >> the said tags. Those are harder to check. Even flagging suspicious tags >> requires a human. If you have some time, consider performing similar checks >> for inline `@jls` and `@jvms` tags in your area. Thanks. >> >> [issues]: https://bugs.openjdk.org/browse/JDK-8339558 >> [JLS]: https://docs.oracle.com/javase/specs/jls/se22/html/index.html >> [JVMS]: https://docs.oracle.com/javase/specs/jvms/se22/html/index.html > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last revision: > > Link to 8.1.3 instead of 8.5.1 > > 8.5.1 was removed in JDK 16. 8.1.3 seems an appropriate substitution. > Alternatively, the link can be deleted altogether. I think we can ignore the title style aspect for now; the key of these tags has always been to provide a correct link to the specs, so fixing trailing period or section number is more important. ------------- Marked as reviewed by liach (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/20879#pullrequestreview-2286639738