On Wed, 4 Sep 2024 17:03:32 GMT, Martin Doerr <mdo...@openjdk.org> wrote:
>> Tier1 test are fine with/without "saving & restoring" return_pc; > > I found it: > https://github.com/openjdk/jdk/blob/433f6d8a0643b59663bf76c0f3a2af27a6cc56b7/src/hotspot/cpu/s390/gc/g1/g1BarrierSetAssembler_s390.cpp#L238 > Called here: > https://github.com/openjdk/jdk/blob/433f6d8a0643b59663bf76c0f3a2af27a6cc56b7/src/hotspot/cpu/s390/gc/g1/g1BarrierSetAssembler_s390.cpp#L115 > Other GCs with load barriers are not implemented, so the save&restore code is > redundant. > The stub is frameless and only needs the save&restore code when calling C. > In this case, no weak references are used, so there's no C call on s390. @JornVernee would you please remove "saving & restoring" code for the return PC as mentioned by Martin. Thanks. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20479#discussion_r1745819490
