On Thu, 5 Sep 2024 13:31:21 GMT, Chen Liang <li...@openjdk.org> wrote:
>> I don't think we should worry too much about making C1 inline more >> aggressively. > > C2 needs 10000 calls to inline this method, so wenshao is worried. However, > this method call is almost always followed by a huge switch to handle > different opcode, so I doubt how much of a difference inlining brings. > > But wenshao discovered that this method has too many field gets; I should > indeed convert them to local variable access if possible. Yes, things like storing `endBci()` to a local variable can be great if it both reduces code size and improves interpreter/C1 speed - but don't over-do it as it's likely never-ending work for a kind of optimizations leyden might make pointless. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20863#discussion_r1745564584
