On Wed, 4 Sep 2024 15:27:40 GMT, Chen Liang <li...@openjdk.org> wrote:
> > I'll see if I can get the benchmarks in > > `test/micro/org/openjdk/bench/jdk/classfile` working. It looks like there > > may be one or more of them which would reach into this code. > > Just checked; no benchmark is currently supplying a manual > `StackMapTableAttribute` to class building, so new benchmark is required. Fyi > this is only used by manual stack map building; internally we use a > `StackMapGenerator.stackMapTableAttribute()` which is an ad-hoc attribute for > writing only. OK. Is this critical for merging the PR? I could likely come up with something but it'd have to wait a bit due to other priorities (this was meant to be a quick Friday task 😅). ------------- PR Comment: https://git.openjdk.org/jdk/pull/20841#issuecomment-2329466089
