On Fri, 30 Aug 2024 20:45:11 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Exclude test on 32-bit
>
> Overall it looks good to me, although I don't have experience adding a new 
> JNI API (the dtrace probes were new to me), but it seems you are following 
> what is already in place for other functions, and the testing looks good.

Thanks for the review @plummercj !

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20784#issuecomment-2323760808

Reply via email to