On Wed, 28 Aug 2024 11:12:42 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
> Please review this test-only PR which addresses several issues with the > `test/jdk/java/util/zip/Available.java` test: > > * The test is converted to JUnit 5 > * The test now creates its own test vector programmatically instead of > relying on a binary `input.jar` test vector > * Coverage is added for calling `available()` after calling > `ZipInputStream.closeEntry`, as expected by the API specification for > `ZipInputStream.available` > * Coverage is added for calling `available()` on a closed `ZipInputStream` > * Coverage is added for the unspecified, but long-standing behavior of > `ZipFileInputStream.available()` (The InputStream returned for `STORED` > entries) > > Additionally, the test is split into multiple methods, adding javadoc > comments for each of them. This pull request has now been integrated. Changeset: f927c121 Author: Eirik Bjørsnøs <eir...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/f927c1210ee0675bb1196572177ffb505826d57a Stats: 119 lines in 1 file changed: 76 ins; 9 del; 34 mod 8339154: Cleanups and JUnit conversion of test/jdk/java/util/zip/Available.java Reviewed-by: lancea ------------- PR: https://git.openjdk.org/jdk/pull/20744