On Wed, 28 Aug 2024 21:24:34 GMT, Chen Liang <li...@openjdk.org> wrote:
>> `TypeKind` enum constants are named in wrong code style; correct them before >> finalization. >> >> Also improved `TypeKind` specification to talk about not mentioned >> `returnType`, `void`, and subword types being erased to int (and how). See >> the associated CSR too. >> >> See the HTML output for the changed `JSpec` taglet's `6.5.newarray` >> rendering: >> https://cr.openjdk.org/~liach/8339115-typekind/java.base/java/lang/classfile/TypeKind.html >> >> Note: when reviewing, please use >> https://cr.openjdk.org/~iris/se/23/spec/draft/java-se-23-draft-spec-37/ >> instead of JVMS 22 for reference; JVMS 23 has fixed a few ambiguities about >> subword types being absent from JVM's stack and locals. > > Chen Liang has updated the pull request incrementally with one additional > commit since the last revision: > > space src/java.base/share/classes/java/lang/classfile/CodeBuilder.java line 564: > 562: case INT -> { > 563: switch (computationalFrom) { > 564: case FLOAT -> f2i(); Actual implementation shows complete conversion table as nested switches. What is the advantage of the proposed change? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20737#discussion_r1735680790
