On Wed, 28 Aug 2024 13:35:19 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix aarch54 > > make/modules/java.desktop/lib/ClientLibraries.gmk line 284: > >> 282: >> 283: ifeq ($(USE_EXTERNAL_HARFBUZZ), true) >> 284: LIBFONTMANAGER_EXTRA_SRC = > > I think this 3space -> 2space indentation change shouldn't be part of this > PR, esp. since 3space is > used in other parts of this file. Really? That is sooo broken. :( But fair enough, I'll do a separate PR on the broken indentation. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20733#discussion_r1734867997
