On Thu, 22 Aug 2024 09:11:03 GMT, Markus Grönlund <mgron...@openjdk.org> wrote:
>> The functional requirement I have is that the branch takes an uncommon trap >> and restarts / re-executes the same method the interpreter, because that >> version enters the VM where an IllegalStateException is thrown. >> >> I don't need the compiled method to be invalidated, only that an attempt >> that over/underflows (thread-local) restarts in the interpeter for the >> exception to be thrown. Is Action_none better suited for this purpose? > > The pattern of the uncommon trap construct was taken from the precedent in > LibraryCallKit::inline_profileBoolean(). Is it an implicit invariant that execution always continues in the interpreter after an uncommon trap? I.e., I don't need to explicitly tell it to "re-execute" there? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20664#discussion_r1726689737
