On Thu, 15 Aug 2024 12:26:38 GMT, David Holmes <[email protected]> wrote:
>> Markus Grönlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> update test comment
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/StringPool.java line 86:
>
>> 84:
>> 85: private static void unpinVirtualThread() {
>> 86: if (Thread.currentThread().isVirtual() &&
>> ContinuationSupport.isSupported()) {
>
> If you are at all concerned about overhead here then pin could return a
> boolean to indicate if the pin happened and oyu could then unpin just by
> checking that boolean and avoid doing the isVirtual and isSupported checks
> again.
Would it be possible to create a boolean in the EventWriter that indicates if
it is associated with a carrier thread or a normal thread (which can never be
virtual) and then have two methods.
long l = this.carrierThread ? StringPool.addPinnedString(s) :
StringPool.addString(s);
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20588#discussion_r1718464765
