On Wed, 24 Jul 2024 19:11:18 GMT, Andrey Turbanov <aturba...@openjdk.org> wrote:
>> Chen Liang has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - More refinements from alex
>> - Artifact -> construct
>> - More about Annotation, add equals note
>
> test/langtools/lib/annotations/annotations/classfile/ClassfileInspector.java
> line 1200:
>
>> 1198: case RuntimeVisibleTypeAnnotationsAttribute rvattr -> {
>> 1199: if (expected.matchVisibility(true)) {
>> 1200: for(var anno : rvattr.annotations()) {
>
> Suggestion:
>
> for (var anno : rvattr.annotations()) {
There are 43 `for(` and 2 `for (` in this file, so fixing a single occurrence
isn't too helpful; for consistency I think you can create a dedicated RFE for
running IDE formatters over all jdk/classfile tests. I will review it if you
submit such a patch.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20247#discussion_r1690320937
