On Thu, 18 Jul 2024 21:27:35 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removed a blank line
>
> src/java.base/share/classes/java/lang/Process.java line 505:
>
>> 503: public boolean waitFor(Duration duration) throws
>> InterruptedException {
>> 504: Objects.requireNonNull(duration, "duration");
>> 505: return waitFor(TimeUnit.NANOSECONDS.convert(duration),
>> TimeUnit.NANOSECONDS);
>
> With this change, the update to ProcessTools is unnecessary and could be
> backed out.
The `ProcessTools` override is a delegating override; I think it still makes
sense and should be kept.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20220#discussion_r1683532105
