On Mon, 15 Jul 2024 13:39:02 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> Indeed, for some reason I thought the range of short is -256 to 255 instead >> of -65536 to 65535 > >> Indeed, for some reason I thought the range of short is -256 to 255 instead >> of -65536 to 65535 > > Yeah, I thought something like this was going on; it would be a smart way to > leverage that negative side in two-complement form is one value larger. But, > `byte` is `-128...127`, and `short` is `-32768..32767`. So current thing > would not even work if it did not support `256` as the value :) > @shipilev Would you re-review this patch, or are you no longer interested now > that `@Stable` is removed? I am not sure I understand the performance implications for this change. I can see the optimization for avoiding `Name` reallocation when we can rewrite the `index` is from original JSR 292 work that introduced LFs. Maybe that optimization is actually not worth it. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20178#issuecomment-2233366471
