On Fri, 12 Jul 2024 13:04:42 GMT, Raffaello Giulietti <rgiulie...@openjdk.org>
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added comment on normalization in MutableBigInteger.sqrtRemZimmermann()
>
> src/java.base/share/classes/java/math/MutableBigInteger.java line 128:
>
>> 126: intLen = 2;
>> 127: value[0] = hi;
>> 128: value[1] = (int) val;
>
> Suggestion:
>
> value = new int[] {hi, (int) val}
> intLen = 2;
In this case, should the same method be applied in the inizialization with an
int?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19710#discussion_r1675924466
