On Thu, 11 Jul 2024 16:46:13 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:

>> Please review this PR which adds test support for systemd slices so that 
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be 
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on 
>> cgroups v1 and fails on cgroups v2 due to the way how 
>> [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) was implemented 
>> when JDK 13 was a thing. Therefore immediately problem-listed. It should get 
>> unlisted once [JDK-8322420](https://bugs.openjdk.org/browse/JDK-8322420) 
>> merges.
>> 
>> I'm adding those tests in order to not regress another time.
>> 
>> Testing:
>> - [x] Container tests on Linux x86_64 cgroups v2 and Linux x86_64 cgroups v1.
>> - [x] New systemd test on cg v1 (passes). Fails on cg v2 (due to  
>> JDK-8322420)
>> - [x] GHA
>
> Severin Gehwolf has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains six additional 
> commits since the last revision:
> 
>  - Add Whitebox check for host cpu
>  - Merge branch 'master' into jdk-8333446-systemd-slice-tests
>  - Merge branch 'master' into jdk-8333446-systemd-slice-tests
>  - Merge branch 'master' into jdk-8333446-systemd-slice-tests
>  - Fix comments
>  - 8333446: Add tests for hierarchical container support

With #17198 and this updated patch I still get the a FAIL due to:

[0.333s][trace][os,container] OSContainer::active_processor_count: 4

But let's resolve it after #17198 gets final/approved.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19530#issuecomment-2225475953

Reply via email to