On Wed, 26 Jun 2024 12:36:17 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Nizar Benalla has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 12 additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'upstream/master' into 8330954
>> - Merge remote-tracking branch 'upstream/master' into 8330954
>> - (C)
>> - (C)
>> - Move security classes changes to pr18373
>> - remove couple extra lines
>> - Pull request is now only about `@since` tags, might add an other commit
>> - add one more `{inheritDoc}` to `CompletableFuture.state`
>> - add `@throws` declarations to javadoc
>> - add ``{@inheritDoc}`` to new javadoc comments
>> - ... and 2 more: https://git.openjdk.org/jdk/compare/82b51c65...dbef517a
>
> src/java.base/share/classes/java/lang/classfile/ClassSignature.java line 44:
>
>> 42: List<Signature.TypeParam> typeParameters();
>> 43:
>> 44: /** {@return the instantiation of the superclass in this signature}
>
> Suggestion:
>
> /**
> * {@return the instantiation of the superclass in this signature}
>
> I think this is our preference if we have multi-line specs.
Fixed in
[91df97f](https://github.com/openjdk/jdk/pull/18954/commits/91df97f7661774bf4f262260e0732507399bce68),
Thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18954#discussion_r1655253281
