On Fri, 7 Jun 2024 20:36:45 GMT, Roger Riggs <rri...@openjdk.org> wrote:

>> I only left it here because the wait for interrupt event was already 
>> present. Is being stuck in a blocking os call a bad thing? If not, I can 
>> drop the interrupt event, and wait on the process handle only.
>
> I think waiting on JVM_GetThreadInterruptEvent() is necessary during VM 
> shutdown to allow the blocked thread to exit cleanly.

Interesting. Could you point me to a related bug / documentation / evidence? I 
tested the WaitForSingleObject version (commit 
6524747a5ebc51c760b14e90309c5f18b58b20e2) on Windows 11, and I didn't observe 
any problems with shutting down the VM

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19586#discussion_r1631678678

Reply via email to