On Fri, 7 Jun 2024 04:47:12 GMT, Joe Darcy <da...@openjdk.org> wrote:
> Misc small doc updates and addition of `@Overrides` annotations. src/java.base/share/classes/java/lang/Double.java line 595: > 593: * This method corresponds to the convertToDecimalCharacter > 594: * operation defined in IEEE 754. > 595: * Does it? IEEE 754 `convertToDecimalCharacter` takes a 2nd argument, the `conversionSpecification` which "specifies the precision and formatting of the _decimalCharacterSequence_ result". There's no such flexibility here. Moreover, there seems to be no way to have a `conversionSpecification` that ensures the "shortest decimal" semantics of this method. Finally, IEEE 754 requires to signal inexact exceptions. Suggestion: * This method vaguely corresponds to the convertToDecimalCharacter The same holds for the other additional `@apiNote`s. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19590#discussion_r1631153540