On Tue, 28 May 2024 20:26:40 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> As a non-standard comment, it will trigger a warning (and hence an error), >> since the prevailing standard for `java.base` is to compile with all >> warnings enabled (`-Xlint`) and no warnings found (verified by `-Werror`) >> >> The alternative would be to use `@SuppressWarnings` for the >> `dangling-doc-comment` warning, but that too would be a code change to these >> imported files. > > OK, we will need to live with it. Yes, while there is a strong preference to leave upstream sources unedited in the JDK, to my mind being able to compile the java.base module with all warnings enabled should take precedence. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19130#discussion_r1618046467
