On Tue, 28 May 2024 16:00:10 GMT, Scott Gibbons <sgibb...@openjdk.org> wrote:

>> test/jdk/java/lang/StringBuffer/IndexOf.java line 28:
>> 
>>> 26:  * @summary Test indexOf and lastIndexOf
>>> 27:  * @run main/othervm IndexOf
>>> 28:  * @run main/othervm -XX:+IgnoreUnrecognizedVMOptions -Xcomp 
>>> -XX:-TieredCompilation -XX:UseAVX=2 -XX:+UnlockDiagnosticVMOptions 
>>> -XX:+EnableX86ECoreOpts IndexOf
>> 
>> I suggest to split it into 2 subtest jobs and use `@requires vm.cpu.features 
>> ~= ".*avx2.*"` for second which specified `-XX:UseAVX=2`.
>> See `compiler/loopopts/superword/TestDependencyOffsets.java` for example.
>
> @vnkozlov I'm getting an error in CI tests with this line added.  Can you 
> please advise?
> 
> `TEST RESULT: Error. Parse Exception: Syntax error in @requires expression: 
> invalid name: vm.cpu.features`

You need to add `vm.cpu.features ` line to `test/jdk/TEST.ROOT` file. Similar 
to what we have in `test/hotspot/jtreg/TEST.ROOT`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1617630712

Reply via email to