On Mon, 15 Jan 2024 13:30:42 GMT, Andrey Turbanov <aturba...@openjdk.org> wrote:
>> Scott Gibbons has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 22 commits: >> >> - Merge branch 'openjdk:master' into indexof >> - Merge branch 'openjdk:master' into indexof >> - Addressing review comments. >> - Fix for JDK-8321599 >> - Support UU IndexOf >> - Only use optimization when EnableX86ECoreOpts is true >> - Fix whitespace >> - Merge branch 'openjdk:master' into indexof >> - Comments; added exhaustive-ish test >> - Subtracting 0x10 twice. >> - ... and 12 more: https://git.openjdk.org/jdk/compare/8e12053e...3e58d0c2 > > test/jdk/java/lang/StringBuffer/IndexOf.java line 220: > >> 218: >> 219: for (int x = 0; x < 1000000; x++) { >> 220: if(make_new) { > > Suggestion: > > if (make_new) { Fixed. > test/jdk/java/lang/StringBuffer/IndexOf.java line 262: > >> 260: } >> 261: >> 262: if(make_new) > > Suggestion: > > if (make_new) Fixed. > test/jdk/java/lang/StringBuffer/IndexOf.java line 295: > >> 293: } >> 294: >> 295: if(make_new) testIndex = getRandomIndex(-100, 100); > > Suggestion: > > if (make_new) testIndex = getRandomIndex(-100, 100); Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1610093771 PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1610094790 PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1610097958
