On Mon, 26 Feb 2024 14:50:30 GMT, Jatin Bhateja <jbhat...@openjdk.org> wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressed some review coments; replaced hard-coded registers with >> descriptive names. > > src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 303: > >> 301: __ subq(rdi, rax); >> 302: __ movq(rdx, rdi); >> 303: __ andq(rdx, -16); > > Hi @asgibbons , may I request you to please use meaningful names instead of > directly using actual GPR names to ease the review process. Done. > src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 777: > >> 775: __ movq(rax, rbx); >> 776: __ movq(rbx, r14); >> 777: __ leaq(r15, Address(r12, -0x2)); > > Kindly use semantically meaningful names instead of direct GPR names. Done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1610121347 PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1610121724
