On Thu, 16 May 2024 13:23:14 GMT, Raffaello Giulietti <rgiulie...@openjdk.org> wrote:
>> Yes, I thought about this the other day but decided for a bit more >> conservative approach, relying on the annotation. >> >> But I agree that, since the meta-information now resides in >> `RandomGeneratorProperties`, we might "migrate" the deprecation status here >> as well. > > Since the legacy generators are public classes, they can be publicly > deprecated, so in the last commit the `DEPRECATED` bit for them still relies > on the annotation, which IMO is the authoritative "source of truth". > > For the 10 other algorithms, which are accessible only via > `RandomFactoryGenerator`, we can rely on the info in `RandomProperties`. The deprecation process of algorithms is unclear - whether it should be tied with the `@Deprecation` of a class that provides that algorithm. We will have more clarity if/when we do deprecate these algorithms. The specification in its current form doesn't tie it to the `@Deprecation` annotation, which is a good thing. So your proposed change in this PR looks fine to me, since it will still allow us to move away from the `@Deprecated` annotation check if we wanted to, in a subsequent release/change. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19212#discussion_r1605058285
