On Tue, 14 May 2024 14:27:35 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> Pavel Rappo has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 17 additional >> commits since the last revision: >> >> - Escape prompt >> - Merge branch 'master' into 8305457-Implement-java.io.IO >> - Clarify input charset >> - Make IO final >> - Fix System.console().readln(null) in jshell >> >> Without it, jshell hangs on me. Will think of a test. >> - Fix typo >> - Merge branch 'master' into 8305457-Implement-java.io.IO >> - Simplify output.exp >> - Cover null prompt in input tests >> - Make input test parametric >> - ... and 7 more: https://git.openjdk.org/jdk/compare/63e13e69...17100ab8 > > src/java.base/share/classes/java/io/IO.java line 98: > >> 96: * or if an I/O error occurs >> 97: */ >> 98: public static String readln(String prompt) { > > Did we consider Optional<String> here? Maybe that is to complicated for an > onramp? Have we considered it? Yes, momentarily. Will we implement it here? No, certainly. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19112#discussion_r1600152722
