On Mon, 13 May 2024 17:06:32 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Making sure `restoreEcho` correctly reflects the state in the shutdown >> thread, which differs from the application's thread that issues the >> `readPassword()` method. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Replaced another unused exception with _ Thanks, Pavel. > While it's hard to test this change (hence the `noreg-hard` label), the > `restoreEcho` functionality does not seem to be tested at all. Should we add > a straightforward test for it, perhaps separately? Filed: https://bugs.openjdk.org/browse/JDK-8332161 ------------- PR Comment: https://git.openjdk.org/jdk/pull/19184#issuecomment-2108282547
