On Fri, 10 May 2024 13:39:42 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:

>> Replace the custom unsigned divide / remainder functions with the 
>> compiler-optimized Long.divideUnsigned / remainderUnsigned.
>> 
>> No new tests. Existing tier1-3 tests continue to pass.
>> 
>> I added a new set of divide benchmarks. Results in thread.
>> 
>> I also removed the BigDecimal.toString benchmarks. They no longer serve 
>> their purpose - toString caches the returned value, so we were only 
>> benchmarking the cache access time.
>
> Daniel Jeliński has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Remove duplicate variable

L.1096-1097 is a 32-bit by 32-bit division; I guess I could change it to use 
Integer.unsignedDivide. Let me look into it...

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19134#issuecomment-2104651245

Reply via email to