On Thu, 9 May 2024 16:57:49 GMT, Joe Wang <jo...@openjdk.org> wrote: >> Naoto Sato has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - Addresses review comment >> - Merge branch 'master' into JDK-8331866-localedata-dependence-warning >> - initial commit > > src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line 157: > >> 155: * Note that the CLDR locale data are subject to change. Users should >> not assume >> 156: * that the locale data remain the same across CLDR versions. >> Otherwise, unexpected >> 157: * incompatible behaviors may occur, such as an exception on parsing a >> date. > > For those wondering what has changed from one version to another or whether a > particular change might have an impact after reading this note, I wonder if > some kind of notes or links might be helpful. A column to the table below to > add some notes? I'm sure they can always look at the CLDR release notes. Just > wonder if there's anything specific worth noting or a link.
IMHO, adding an extra column to describe what has changed in CLDR would seem impractical as the significance of the changes depends on each reader. Instead, I added a sentence to navigate readers to CLDR's releases page for the deltas. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19145#discussion_r1595794498
