On Wed, 8 May 2024 08:33:31 GMT, Alan Bateman <[email protected]> wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> small grammar fixes
>
> src/java.base/share/classes/java/lang/ref/Cleaner.java line 224:
>
>> 222: * Actions in a thread prior to calling {@code Cleaner.register()}
>> 223: * <a
>> href="{@docRoot}/java.base/java/util/concurrent/package-summary.html#MemoryVisibility"><i>happen-before</i></a>
>> 224: * the cleaning action is run by the Cleaner's thread.
>
> In passing, you could reduces the html refs to
> "package-summary.html#MemoryConsistency" and
> "package-summary.html#MemoryVisibility" as it's the same package/directory.
MemoryVisibility is in java.util.concurrent 😉
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16644#discussion_r1594785182
