On Fri, 23 Feb 2024 14:37:20 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> VM -> virtual machine; also fix misspelling > > src/java.base/share/classes/java/lang/ref/Cleaner.java line 218: > >> 216: * cautions about the behavior of cleaning actions. >> 217: * >> 218: * <p>The object being registered is kept strongly reachable (and >> therefore not eligible > > I would be tempted to drop "being registered" from this sentence. The > previous paragraph and the parameter descriptions use "the object". That > would make it "The given object is kept strongly reachable ..." which I > think is a bit easier to read. If it's clear which object is meant, then yes, that reads better. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16644#discussion_r1594756233