On Wed, 8 May 2024 05:41:52 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Strengthen tests after 8330998 >> >> https://github.com/openjdk/jdk/pull/18996 now allows us to test >> Console IO better. > > src/java.base/share/classes/java/io/Console.java line 188: > >> 186: >> 187: /** >> 188: * Writes a prompt as if by calling {@code print}, then reads a >> single line > > Should `{@code print}` instead be `{@link Console#print() print()}`? It could be done like that, but given that it's the same class (and the same HTML page), I'd skip it. > src/java.base/share/classes/java/io/Console.java line 192: > >> 190: * >> 191: * @param prompt >> 192: * A prompt string. > > Hello Pavel, should this specify whether `prompt` can be null? If we specify that, it would be very much unlike all other `Console` methods that are covered by this: * Unless otherwise specified, passing a {@code null} argument to any method * in this class will cause a {@link NullPointerException} to be thrown. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19112#discussion_r1593687355 PR Review Comment: https://git.openjdk.org/jdk/pull/19112#discussion_r1593684673
