On Tue, 7 May 2024 16:32:46 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Please review this PR which introduces the `java.io.IO` top-level class and >> three methods to `java.io.Console` for [Implicitly Declared Classes and >> Instance Main Methods (Third Preview)]. >> >> This PR has been obtained as `git merge --squash` of a now obsolete [draft >> PR]. >> >> [Implicitly Declared Classes and Instance Main Methods (Third Preview)]: >> https://bugs.openjdk.org/browse/JDK-8323335 >> [draft PR]: https://github.com/openjdk/jdk/pull/18921 > > test/jdk/java/io/IO/IO.java line 99: > >> 97: System.getProperty("test.jdk") + "/bin/java", >> 98: "--enable-preview", >> 99: "-Djdk.console=gibberish", > > The test comment suggests this test is testing the default console > implementation, but the invocation specifies `-Djdk.console=gibberish` which > defaults to java.base. Is this what you intended? That comment says that this test tests jdk.internal.io.JdkConsoleImpl, which belongs to java.base. But, if you read it the way you described, I should definitely rephrase it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19112#discussion_r1592824491
