On Mon, 6 May 2024 20:48:05 GMT, Chen Liang <li...@openjdk.org> wrote:
> A peek into TypeKind during the research for #19105 reveals that TypeKind has > a few issues: > 1. Name mismatch for `newarraycode` and `fromNewArrayCode`: Renamed both to > use "newarray code" > 2. `fromDescriptor` can throw IOOBE if the input string is empty: changed to > throw IAE and added tests. > 3. `from(Class)` can be slow due to descriptor computation: added benchmark, > will share result in next comment (as it may change with code changes). > > The first 2 changes involves API changes, and a CSR has been created. > Requesting @asotona for a review. test/micro/org/openjdk/bench/java/lang/classfile/TypeKindBench.java line 52: > 50: @Warmup(iterations = 3, time = 2) > 51: @Measurement(iterations = 6, time = 1) > 52: @Fork(1) Suggestion: @Fork(jvmArgsAppend = "--enable-preview", value = 1) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19109#discussion_r1591587643
