On Mon, 29 Apr 2024 18:41:44 GMT, Naoto Sato <na...@openjdk.org> wrote:
> Looks good to me. Left some minor suggestions. BTW, should we file an issue > at the `JLine` project, not to redirect to stderr, or suggest a new config > (sorry if it has already been taken care of)? The code to choose the output stream is quite elaborate, so I assume that is intentional. For new versions of JLine, the `systemOutput(SystemOutput.SysOut)` forces the use of stdout, however, so the patch to JLine itself will not be needed anymore after we upgrade. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18996#issuecomment-2088894660
