On Wed, 10 Apr 2024 23:56:52 GMT, Volodymyr Paprotski <d...@openjdk.org> wrote:
> Few early comments. > > Please update the copyright year of all the modified files. > > You can even consider splitting this into two patches, Java side changes in > one and x86 optimized intrinsic in next one. Fixed all copyright years git diff da8a095a19c90e7ee2b45fab9b533a1092887023 | lsdiff -p1 | while read line; do echo $line =========================; grep Copyright $line | grep -v 2024; done | less Re splitting.. probably too late for that now.. (did consider it initially.. got hard to manage two changes while developing. And easier to justify the change when the entire patch is presented? but yes, far more code to review.. ) ------------- PR Comment: https://git.openjdk.org/jdk/pull/18583#issuecomment-2057892691
