On Fri, 12 Apr 2024 00:10:22 GMT, Sandhya Viswanathan 
<sviswanat...@openjdk.org> wrote:

>> Scott Gibbons has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Addressing yet more review comments
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 2521:
> 
>> 2519:       const Register byteVal = rdx;
>> 2520: 
>> 2521:       // Propagate byte to full Register
> 
> The comment refers to lines 2524-2526, please move it down.

Still continuing to look through StubGenerator::generate_unsafe_setmemory(), 
more comments to come. Thank you for your patience.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18555#discussion_r1561878666

Reply via email to