On Wed, 10 Apr 2024 10:59:25 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> This PR removes support for the string template feature from the Java >> compiler and the Java SE API, as discussed here: >> >> https://mail.openjdk.org/pipermail/amber-spec-experts/2024-April/004106.html > > Maurizio Cimadamore has updated the pull request incrementally with one > additional commit since the last revision: > > Fix issues in digit classes javac and JShell changes look good to me (with a nit in JShell tests). For consideration: using `{` will now produce the "illegal escape character" error. Which is technically correct, but maybe we could add a special error, saying that StringTemplates are removed for now? So that if someone will try to compile source code with StringTemplates, they would now this was intentional. Just for consideration. test/langtools/jdk/jshell/CompletionSuggestionTest.java line 327: > 325: assertSignature("String.format(|", > 326: "String String.format(String, Object...)", > 327: "String String.format(java.util.Locale, String, > Object...)" Nit: this change appears to be unnecessary? ------------- Marked as reviewed by jlahoda (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18688#pullrequestreview-1993673798 PR Review Comment: https://git.openjdk.org/jdk/pull/18688#discussion_r1560692978
